Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move calls to pack download to the init action #1218

Merged
merged 3 commits into from
Aug 30, 2022

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Aug 26, 2022

This ensures all steps to gather queries happens in the init action. This is where checking out queries in other repos happens as well.

This change is a refactoring that facilitates future changes. In particular, this will help when implementing package download from GHES.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner August 26, 2022 20:48
@aeisenberg aeisenberg marked this pull request as draft August 26, 2022 20:48
@aeisenberg aeisenberg force-pushed the aeisenberg/move-pack-download-to-init branch from f37d008 to a666267 Compare August 26, 2022 21:13
@aeisenberg aeisenberg changed the title Moves calls to pack download to the init action Move calls to pack download to the init action Aug 26, 2022
@aeisenberg aeisenberg force-pushed the aeisenberg/move-pack-download-to-init branch 3 times, most recently from 1e0fc04 to 8948fab Compare August 26, 2022 22:35
This ensures all steps to gather queries happens in the init action.
This is where checking out queries in other repos happens as well.
@aeisenberg aeisenberg force-pushed the aeisenberg/move-pack-download-to-init branch from 8948fab to 354bc9f Compare August 26, 2022 23:05
@aeisenberg aeisenberg marked this pull request as ready for review August 29, 2022 15:45
src/config-utils.ts Outdated Show resolved Hide resolved
src/config-utils.ts Outdated Show resolved Hide resolved
src/config-utils.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment about the log messages, otherwise LGTM.

src/config-utils.ts Outdated Show resolved Hide resolved
Also, rename variable and change a comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants